-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI: Add Slack notifications for rel/nightly failures #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetechnical
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my quick grok it looks fine, but I guess we need to merge it to see
algojack
approved these changes
Aug 10, 2021
This was referenced Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add slack notifications for rel/nightly failures.
This will help us easily track Circle CI rel/nightly test failures on our slack channel.
Details
I leveraged the following article: https://circleci.com/blog/circleci-slack-integration/
and this wiki: https://github.com/CircleCI-Public/slack-orb/wiki/Setup
We currently disable "Pass secrets to builds from forked pull requests" in our Circle CI configurations to protect our environment variables., so I'm unable to test this change until it runs on the official go-algorand repo. The notification changes are only applied to "nightly" tests failures on the "rel/nightly" branch.
Future
After implementing notifications on the "rel/nightly" branch in this PR, we can consider changing the filter to all release branches.